Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename and move getChart to handlerutil #1387

Merged
merged 1 commit into from
Dec 16, 2019
Merged

Rename and move getChart to handlerutil #1387

merged 1 commit into from
Dec 16, 2019

Conversation

SimonAlling
Copy link
Contributor

I'm planning to use it in Kubeops as well.

I renamed it because I think ParseAndGetChart is more descriptive of what it actually does.

andresmgot
andresmgot approved these changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andresmgot andresmgot merged commit 2e718a1 into vmware-tanzu:master Dec 16, 2019
@SimonAlling SimonAlling deleted the move-getchart branch December 16, 2019 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresmgot andresmgot andresmgot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonAlling @andresmgot