[kubeops] Add tests for CreateRelease #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absoludity
approved these changes
Jan 6, 2020
There was a problem hiding this comment.
Looks good. See my comments on the previous diff RE using go-cmp and subtests instead of logging.
One thing that I'm unclear about: do we have a use-case for creating releases without auth? This smells of something which was in tiller-proxy from before authz was explicitly required, so I'm not sure we want to be copying this across... but if it's already in the actual code being tested, OK.
|
Looks like this needs to be rebased on master (removing the commits which are now already in master)? Either way, happy to land once the conflict is resolved : |
- Extend tests for /pkg/agent to include create release - Add create release tests scenarios in /kubeopps/internal/handler
latiif
force-pushed
the
test-helm3-create-release
branch
from
8d6d7ce to
784e14e
Compare
|
Now it's based on the latest upstream master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds tests for the functionality of creating releases with Helm 3.
Tests the functionality in both the HTTP handler and
/pkg/agent(Helm 3 library wrapper).Analogous to the tests done for
tiller-proxyin/cmd/tiller-proxy/internal/handlerand/pkg/proxyBenefits
Covers and tests CreateRelease #1399
Applicable issues
Should be merged after #1408