Use logrus consistently for logging #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
reviewed
Jan 7, 2020
There was a problem hiding this comment.
Thanks @SimonAlling! I was checking the CI and I noticed it failed because there is a flag that can be used only with glog in the apprepository-controller so you will need to remove it: --logtostderr here:
https://github.com/kubeapps/kubeapps/blob/master/chart/kubeapps/templates/apprepository-deployment.yaml#L44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
It replaces
github.com/golang/glogandk8s.io/klogwithgithub.com/sirupsen/logrus.Benefits
Possible drawbacks
Before this PR,
Vfromglogwas sometimes used, for example like this:This PR simply replaces
glog.V(4)withlog, which might affect verbosity. I don't know if this matters.Applicable issues