Set unique chart ID column #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absoludity
approved these changes
Jan 12, 2020
| @@ -112,38 +110,22 @@ func (m *postgresAssetManager) UpdateLastCheck(repoName, checksum string, now ti | |||
| } | |||
|
|
|||
| func (m *postgresAssetManager) importCharts(charts []models.Chart) error { | |||
| txn, err := m.DB.Begin() | |||
There was a problem hiding this comment.
Why are you also removing the transaction for importing the charts?
There was a problem hiding this comment.
I forgot to explain that. The only supported method when doing a transaction is COPY FROM (https://godoc.org/github.com/lib/pq#hdr-Bulk_imports). That was the reason for a chart to be added several times to the database. Once I set the unique column, that method started to fail because "there was already an entry with that unique ID".
I tried to use a custom query (instead of COPYing) but arguments were not supported. The only way I found to safely do this was to execute one query per chart (and it didn't have a noticeable impact in the performance).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Not setting a unique varchar column with PostgreSQL was causing the application to show duplicates instead of updating the existing chart. Now the chart ID (e.g.
bitnami/apache) is used as that unique column.Possible drawbacks
It requires deleting the existing table (or restarting postgres pods) but the feature has not been released yet.