Refactor Kubeops routes code #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benefits: * Easier to define routes in `main`. * Reduced code repetition. * Less clutter, highlighting actual content. * Less room for mistakes. Drawbacks: * Routes are forced to be very similar in behavior to each other.
andresmgot
approved these changes
Jan 10, 2020
Yeah. Go's absence of (general) type inference sure doesn't help either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
It introduces an abstraction for defining routes, making the definitions clearer, shorter and DRYer.
Benefits
main.Possible drawbacks