[PG] Return latest chart version #1433
Conversation
cmd/assetsvc/postgresql_utils.go
Outdated
| c.ChartVersions = []models.ChartVersion{cv} | ||
| if _, found := containsVersionAndAppVersion(c.ChartVersions, version, appVersion); found { | ||
| // Return only the latest ChartVersion | ||
| c.ChartVersions = []models.ChartVersion{c.ChartVersions[0]} |
There was a problem hiding this comment.
This looks like the wrong place to change the data? The function is getChartsWithFilters(), which should return all charts which match the filter. If I were to see this function and re-use it for some other purpose, it'd be very surprising that it actually modifies the result (truncating the chart versions for the chart).
So my question is: why does this function need to truncate the chart versions for the returned charts at all?
The specific call-site in this case (the handler) can choose to overwrite c.ChartVersions = []models.ChartVersion[c.ChartVersions[0] if the handler should return just the one chart version, but I don't think it should be part of this util function?
There was a problem hiding this comment.
I actually agree, my bad reason to do this is because in the mongodb-utils it's done this way. There, I believe the reason we are doing this is because of the performance. It's encoded in the MongoDB query so it's only returning one version which I believe is faster.
In any case, it's not the case here so I am okay changing the behavior.
[EDIT] Actually there is already code in the dashboard to get the latest version so this seems to be unnecessary.
Description of the change
It's not explicit but the
chartVersionreturned bygetChartsWithFiltersshould be the latest version in order to return it to the client. That's is later used by the dashboard to determine if there are updates available. Since the charts are ordered, it should return the first one of the array.