[Helm3] Use default chart values for rendering the Changes tab when upgrading #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absoludity
approved these changes
Jan 13, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
In Helm 3, the
rawvalues used to install a chart are no longer persisted in the cluster. We were using those values to show the difference between the new values to be installed and the existing values (when upgrading).Since we can't do that anymore, we can still compare the original values plus any modification made that are actually stored.
Benefits
It's possible to show real changes between versions using Helm 3:
Possible drawbacks
As explained in #1423, any modification made as comments will be lost (since those comments are not persisted anywhere).
Applicable issues
Additional information