Use error wrapping to test without string comparison. #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absoludity
changed the title
This was referenced Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
In #1445 I removed some detail from an error because I couldn't figure out a good way to test the situation (without resorting to string comparisons). I had tried to use the new error wrapping ability, but since the underlying error (from
ptypes.timestamp) doesn't return or expose a standard error, I was unable to useerrors.Is()to identify it.With a fresh mind this morning, I realised that
fmt.Errorfintentionally allows you to wrap either error while still maintaining the same error string in the result. That allows this simple change to work. See what you thinkBenefits
Allows handling errors and identifying our own errors using
errors.Isas is done here in a test (but not restricted to tests).Additional information
This is an alternative to #1447