Remove duplicated ingress in chart

[andresmgot]

Description of the change

When enabling the ingress setup, two hosts with identical information are generated. One because the hostname is set and another one because the section hosts is also configured (the legacy mechanism to set ingresses).

cc/ @juan131

[juan131]

LGTM

[absoludity]

+1, but see inline comment.

[absoludity]

Since .Values.ingress.enabled is false by default, won't removing the defaults for this deprecated option be a backwards incompatible change? (ie. as per the comment, something that should wait for 3.0.0)

Could we instead just add a condition around the host block, like:

## The block below is deprecated and must removed on 3.0.0 
{{- if not (eq Values.ingress.hostname .name) }}
- host: {{ .name }
  ...
{{- end }}

[andresmgot]

It won't be a breaking change because:

• If the user has enabled: true and the hosts section has some custom parameters, reusing those values would work in the same way.
• If the user has enabled: true and the hosts were left by default, upgrading will introduce the new hostname: kubeapps.local which will result in the same result.

Note that if enabled is false, nor the hostname or the hosts properties are taken into account.