ChartView: Skip comments and render hash links #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absoludity
approved these changes
Jan 23, 2020
| if (props.href.startsWith("#")) { | ||
| return <Link to={props.href}>{props.children}</Link>; | ||
| } | ||
| return <a href={props.href}>{props.children}</a>; |
There was a problem hiding this comment.
Why don't we use the normal Link here from react-router-dom that we use elsewhere? Ah, because this LinkRenderer is only being used for rendering the README, so it will never contain internal application links - got it. Not sure if it's worth a comment, up to you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Ignore comments and fix hash links in the ChartView.
Apparently React-Router doesn't play well with hash links so I had to add a new dependency:
remix-run/react-router#394 (comment)
Tested with the ChartMuseum chart. This is before the change:
And this is with this fix, the comment is removed and the link works:
Applicable issues