Update instructions to use Harbor as a Private Repository #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: juan131 <juan@bitnami.com>
juan131
changed the title
absoludity
approved these changes
Jan 28, 2020
There was a problem hiding this comment.
Thanks Juan. Happy to have this updated to the bitnami chart. The reason it was using upstream is because this was contributed by the Harbor folk (see #1083 ).
Note: these instructions allow you to add a private repository in Harbor, but not necessarily install the charts from that private repository unless all the images are public or you've manually added and configured an image pull secret when you deploy. If you're interested in contributing to the discussion, we're outlining a design in Kubeapps chart installation from private repositories :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: juan131 juan@bitnami.com
Description of the change
This PR updates the instructions to use Harbor as a Private Repository.
It adapts the instructions to use the Bitnami Harbor Helm Chart to install Harbor through Kubeapps (following the same approach used for Chartmuseum instructions).
Benefits
Possible drawbacks
None