Add support to 'textarea' render type on basic forms #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juan131
requested review from
absoludity and
andresmgot
and removed request for
absoludity
andresmgot
reviewed
Jan 29, 2020
There was a problem hiding this comment.
Thanks for the PR @juan131! Let me know what you think about my comment.
dashboard/src/components/DeploymentFormBody/BasicDeploymentForm/BasicDeploymentForm.tsx
Outdated
Show resolved
Hide resolved
dashboard/src/components/DeploymentFormBody/BasicDeploymentForm/TextAreaParam.tsx
Outdated
Show resolved
Hide resolved
added 3 commits
January 30, 2020 14:52
Signed-off-by: juan131 <juan@bitnami.com>
Signed-off-by: juan131 <juan@bitnami.com>
Signed-off-by: juan131 <juan@bitnami.com>
juan131
force-pushed
the
textarea-deployment-form
branch
from
1ee2187 to
bd1e986
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: juan131 juan@bitnami.com
Description of the change
This PR adds support for a new render type on basic forms: "textArea"
This new render type can be very useful to add configuration blocks (multiline strings) with a more user-friendly interface. Check the example below using changes at helm/charts#20426:
Benefits
More possibilities for chart developers to create their values.schemas.json
Possible drawbacks
None
Applicable issues