Improve CI tests based on bash best practices #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: juan131 <juan@bitnami.com>
absoludity
approved these changes
Jan 30, 2020
Signed-off-by: juan131 <juan@bitnami.com>
andresmgot
approved these changes
Jan 30, 2020
There was a problem hiding this comment.
Thanks for the improvements @juan131
I have sent you an invitation for the kubeapps organization. With that you should be able to run any job with ssh so you can debug what's failing:
Let me know if you need help!
added 3 commits
January 30, 2020 10:53
Signed-off-by: juan131 <juan@bitnami.com>
Signed-off-by: juan131 <juan@bitnami.com>
Signed-off-by: juan131 <juan@bitnami.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: juan131 juan@bitnami.com
Description of the change
Improves CI tests scripts based on bash best practices.
Benefits
Possible drawbacks
I might break the CI tests 🤣