1495 2 app repository cluster role #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absoludity
force-pushed
the
1495-2-app-repository-cluster-role
branch
from
3bf0722 to
9e0832f
Compare
andresmgot
reviewed
Feb 4, 2020
| @@ -32,6 +32,18 @@ rules: | |||
| - jobs | |||
| verbs: | |||
| - create | |||
| --- | |||
| # Kubeapps can read and watch its own AppRepository resources cluster-wide. | |||
There was a problem hiding this comment.
shouldn't we enable this behind a feature flag for the moment? that way we avoid "breaking" changes in the chart while the feature is being developed
There was a problem hiding this comment.
I can put it behind a flag, but didn't see much point given that this doesn't affect existing behaviour, just enables the features which will themselves be behind a feature flag to work properly. Let me update.
There was a problem hiding this comment.
given that this doesn't affect existing behaviour
well it affects in the sense that we are now installing a cluster wide resource (apart than the CRD)
absoludity
changed the base branch from
1495-1-app-repository-cluster-role
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #1497 . Updates the app repository controller to be granted a clusterrole and clusterrolebinding to read AppRepositories.
I've used an easily identifiable and descriptive name for the clusterrole (rather than the templated
kubeapps.apprepository.fullname), while ensuring it is unique per Kubeapps installation (appending the namespace).Ref #1495