Move HTTP functionality of apprepo to another package #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
force-pushed
the
httpHandler
branch
from
a8d3055 to
f90741a
Compare
absoludity
approved these changes
Feb 12, 2020
| // in Kubeapps, without exposing implementation details to 3rd party integrations. | ||
| type appRepositoriesHandler struct { | ||
| type AppRepositoriesHandler struct { |
There was a problem hiding this comment.
Not sure if this, the conversion from private to public, was done before you created the interface below... I don't see it being accessed outside this module?
There was a problem hiding this comment.
Apart from that, I was getting a lint warning because the public method NewAppRepositoriesHandler was returning this private struct.
|
Landing to continue work in the handle. Thanks for pushing this so we can move without stacking branches :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Move HTTP related code out of
pkg/appreposo this package can be re-used in other packages (pkg/chart) later on.This is part of the refactoring I mention in #1507
Additional information
I still need to add tests for
pkg/http-handler(to check that it returns the expected response/code but I wanted to send something first to avoid conflicts.