Use correct secret in kubeapps namespace when syncing an app repo #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m another namespace.
andresmgot
approved these changes
Feb 18, 2020
| } | ||
| } | ||
|
|
||
| // jobSpec returns a batchv1.JobSpec for running the chart-repo sync job | ||
| func syncJobSpec(apprepo *apprepov1alpha1.AppRepository) batchv1.JobSpec { | ||
| func syncJobSpec(apprepo *apprepov1alpha1.AppRepository, kubeappsNamespace string) batchv1.JobSpec { |
There was a problem hiding this comment.
here (line 457) you also need to change the secretKeyRef?
Comment on lines
587
to
589
| if apprepo.ObjectMeta.Namespace != kubeappsNamespace { | ||
| secretKeyRef.LocalObjectReference.Name = kube.KubeappsSecretNameForRepo(apprepo.ObjectMeta.Name, apprepo.ObjectMeta.Namespace) | ||
| } |
There was a problem hiding this comment.
I wonder if it would be simpler to just create a copy of the apprepo in the kubeapps namespace. That would help with the garbage collection and wouldn't require to change these secret references on the fly
There was a problem hiding this comment.
It would, if we weren't transitioning towards an end goal of syncing across all namespaces and running the jobs in those namespaces. This way we can begin syncing AppRepos across namespaces, we are just still running the sync jobs in the kubeapps namespace until we can update the assetsvc to receive data from the syncer.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the cronjob spec so that, when an app repository is from a namespace other than kubeapps, the correct secret ref is used for the repo.
Ref: #1521 .