Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubeops manifests to follow YAML best practices #1528

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

juan131
Copy link
Contributor

@juan131 juan131 commented Feb 18, 2020

Signed-off-by: juan131 juan@bitnami.com

Description of the change

This PR adapts the manifests for Kubeops so they're consistent with the rest of manifests. It also ensure that yamllint doesn't complain about the syntax.

Benefits

  • Consistency
  • Better Readability

Possible drawbacks

None

Signed-off-by: juan131 <juan@bitnami.com>
Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@absoludity absoludity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, LGTM. I guess the combitech folk had copied this from tiller-proxy before you'd updated those.

@absoludity absoludity merged commit 4ab27c4 into vmware-tanzu:master Feb 18, 2020
@juan131 juan131 deleted the kubeops-non-root branch February 19, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants