Setup test infra for mongo tests. #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
approved these changes
Feb 27, 2020
Yeah, I was going to ask whether you thought it'd be deprecated or left. I wasn't sure if I'd be needing to support both mongo and postgres when later doing the changes for asset sync jobs in namespaces, if so it'd be worth investing, but if not then I'm keen to avoid mongo as much as possible :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #1521
This PR just refactors a little so that the pg and mongo test helpers can live separately (and so be namespaced with the same function names), and adds an initial test using mongodb.
Following PR starts updating the mongo backend safely with namespaces.