Show operator instance types in the catalog #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absoludity
approved these changes
Mar 16, 2020
| checked={listOperators} | ||
| onChange={this.toggleListOperators} | ||
| /> | ||
| <span>Operator Instances</span> |
There was a problem hiding this comment.
We're using the technical name "operator instances" here, but I wonder if it'd be better from a user pov to just filter by "operators" (vs charts)?
There was a problem hiding this comment.
Right, I used Operators first but I thougth it could be confusing with the operators view. In any case you are probably right.
| }); | ||
| }); | ||
| }); | ||
| return result; |
There was a problem hiding this comment.
Looks like this is returning all charts followed by all operators? Should the catalog result be sorted in some way?
There was a problem hiding this comment.
It is. Probably is more intuitive to have them mixed and ordered alphabetically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR adds support for showing Operator instance types in the Catalog view along with available charts. To improve the discover-ability of those instances, there is a column filter that you can use to list only charts or operators (which is only rendered if there are operators available).
Fun fact: The icons are now encrypted in base64 in the CSV definition
Applicable issues