Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt kubeapps chart to stable deprecation #1587

Merged
merged 2 commits into from
Mar 17, 2020
Merged

Adapt kubeapps chart to stable deprecation #1587

merged 2 commits into from
Mar 17, 2020

Conversation

carrodher
Copy link
Contributor

Description of the change

Bitnami charts are no longer updated in the stable repository. This PR updates some references/links in the docs and also the requirements.yaml to pull the dependencies from the updated repository.

+info: helm/charts#20969

Possible drawbacks

As the bitnami repository already contains all the bitnami contributed charts, there are no drawbacks because:

  • Changes in the docs shouldn't affect anything
  • Charts included as deps are already in the "new" repository (new in terms of kubeapps requirements.yaml)

Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carrodher
Copy link
Contributor Author

Just for the records.
826b756 is needed when testing with Helm 2.14 because a bug/issue in Helm itself solved in 2.15.

I was able to reproduce it using Helm 2.14.0:

$ helm214 dep update
Error: no repository definition for https://charts.bitnami.com/bitnami, https://charts.bitnami.com/bitnami. Please add them via 'helm repo add'

while the issue doesn’t appear in Helm 2.16.1:

$ helm216 dep update
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "stable" chart repository
Update Complete.
Saving 2 charts
Downloading mongodb from repo https://charts.bitnami.com/bitnami
Downloading postgresql from repo https://charts.bitnami.com/bitnami
Deleting outdated charts

Solved here: helm/helm#6258

We fixed it adding the repository because it's useful for us to test kubeapps using previous Helm versions.

@andresmgot andresmgot merged commit b73a62b into vmware-tanzu:master Mar 17, 2020
@carrodher carrodher deleted the stableDeprecation branch March 17, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants