Several fixes for operators #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 24, 2020 16:20
absoludity
approved these changes
Mar 26, 2020
| @@ -49,6 +49,7 @@ describe("chartReducer", () => { | |||
| ...initialState.selected, | |||
| error, | |||
| }, | |||
| }, | |||
There was a problem hiding this comment.
Hrm, I normally see the build process (react-scripts-ts build) to catch syntactical issues like this? Ah, perhaps because that's doing a production build, it doesn't check test files? Just surprised that it got through.
There was a problem hiding this comment.
I think so, I got the error trying to commit this, the pre-check that is done before commiting was failing so I guess it's an issue with react-scripts-ts.
dashboard/src/shared/types.ts
Outdated
| @@ -269,7 +273,7 @@ export interface IPackageManifest extends IResource { | |||
| export interface IClusterServiceVersionCRDResource { | |||
| kind: string; | |||
| name: string; | |||
| version: string; | |||
| version?: string; | |||
There was a problem hiding this comment.
Why isn't this required for the resource?
There was a problem hiding this comment.
actually it's required but it was not being used, re-added
added 2 commits
March 26, 2020 10:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
I have tried with a different operator and found several issues:
backendref. I have adapted the AccessURLItem to cover that case.kindproperty is not available when the resource is extracted from a list. UseselfLinkinstead.statusand thespecof an operator instance is missing sometimes. Don't show the related information in that case.This an example of those fixes for the jaeger operator:
Applicable issues