Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show proper message when there are no workloads or URLs #1615

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

andresmgot
Copy link
Contributor

Description of the change

Two small bug fixes:

  • When there are no workloads, say that instead of "Ready" since we cannot ensure that the application is actually ready.
  • When there are no URL items, skip the URL table

Before these changes:
Screenshot from 2020-03-30 17-11-13

After:
Screenshot from 2020-03-30 17-14-17

Applicable issues

Copy link
Contributor

@absoludity absoludity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small bug fixes:

* When there are no workloads, say that instead of "Ready" since we cannot ensure that the application is actually ready.

+1 to say something other than Ready, but would have thought it'd be better to do that only, ie. still show the circle, but rather than "Ready", just have "No workload" or similar? (so it still shows zero pods, but that's expected, just means it won't jump or change significantly when updating).

* When there are no URL items, skip the URL table

Great, at first I had a similar comment that it'd be better to say there are no publicly exposed URIs, but I see from the code that this is the case when a service/ingress is present, the table only being removed if there are no services or ingress.

@andresmgot
Copy link
Contributor Author

+1 to say something other than Ready, but would have thought it'd be better to do that only, ie. still show the circle, but rather than "Ready", just have "No workload" or similar? (so it still shows zero pods, but that's expected, just means it won't jump or change significantly when updating).

The thing is that showing 0 Pods would be wrong. For example, the spark-cluster from the screenshot does have Pods (defined by a replication-controller that doesn't define an ownerReference). So if we say that there are no pods or simply "no workloads" it would be wrong: there are, but we cannot detect them.

Also, the circle is meant so show progress. If there is no progress to show I would find it a bit weird.

@andresmgot andresmgot merged commit 5ba52be into master Mar 31, 2020
@andresmgot andresmgot deleted the emptyURLAndWorkload branch March 31, 2020 09:29
@absoludity
Copy link
Contributor

The thing is that showing 0 Pods would be wrong. For example, the spark-cluster from the screenshot does have Pods (defined by a replication-controller that doesn't define an ownerReference). So if we say that there are no pods or simply "no workloads" it would be wrong: there are, but we cannot detect them.

Also, the circle is meant so show progress. If there is no progress to show I would find it a bit weird.

Oh, I thought it was a temporary state - ie. No pods/workloads currently (but there will be soon, ie. the UI would update). If that's not the case, great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants