Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OtherResources table to the operator view #1618

Merged
merged 2 commits into from
Apr 1, 2020

Conversation

andresmgot
Copy link
Contributor

Description of the change

Add the Other Resources table to the Operator view to complete the view:

Screenshot from 2020-03-31 13-35-29

Note that even though we are just interested on knowing the name of the resources, we need to request the list of resources (in a namespace) and filter out.

There are a few tricky things in this PR:

  1. Some resources listed are not shown later. For example, an Operator may define Pods as one of the resource it creates but since those pods are not directly linked to the Operator CRD (the Deployment is instead), these resources are not shown in the table.
  2. Apart from the current workaround of guessing the apiVersion/plural, I needed to differentiate between namespaced and non-namespaced resources. This is becoming too hacky... but would work now for the alpha release.

To avoid any issues with the current approach for charts, we are maintaining the old behavior for helm releases (not requesting nor watching "other resources").

Applicable issues

@andresmgot andresmgot merged commit 8bcad6b into master Apr 1, 2020
@andresmgot andresmgot deleted the otherResourcesOperators branch April 7, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants