Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link in Deploy App buton #1643

Merged
merged 2 commits into from
Apr 8, 2020
Merged

Fix broken link in Deploy App buton #1643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04dce19
Fix broken link in Deploy App buton
Apr 7, 2020
c70a503
Fix link in Catalog card
Apr 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dashboard/src/components/AppList/AppList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ class AppList extends React.Component<IAppListProps, IAppListState> {
const {
apps: { error, isFetching },
isFetchingResources,
namespace,
} = this.props;
return (
<section className="AppList">
Expand All @@ -75,7 +76,7 @@ class AppList extends React.Component<IAppListProps, IAppListState> {
</div>
<div className="col-3 text-r align-center">
{!error && (
<Link to="/catalog">
<Link to={`/ns/${namespace}/catalog`}>
<button className="deploy-button button button-accent">Deploy App</button>
</Link>
)}
Expand Down
12 changes: 6 additions & 6 deletions dashboard/src/components/AppList/__snapshots__/AppList.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ exports[`when apps available matches the snapshot 1`] = `
className="col-3 text-r align-center"
>
<Link
to="/catalog"
to="/ns/default/catalog"
>
<button
className="deploy-button button button-accent"
Expand Down Expand Up @@ -117,7 +117,7 @@ exports[`when custom resources available matches the snapshot 1`] = `
className="col-3 text-r align-center"
>
<Link
to="/catalog"
to="/ns/default/catalog"
>
<button
className="deploy-button button button-accent"
Expand Down Expand Up @@ -277,7 +277,7 @@ exports[`when fetched but not apps available matches the snapshot 1`] = `
className="col-3 text-r align-center"
>
<Link
to="/catalog"
to="/ns/default/catalog"
>
<button
className="deploy-button button button-accent"
Expand Down Expand Up @@ -348,7 +348,7 @@ exports[`while fetching apps loading spinner matches the snapshot 1`] = `
className="col-3 text-r align-center"
>
<Link
to="/catalog"
to="/ns/default/catalog"
>
<button
className="deploy-button button button-accent"
Expand Down Expand Up @@ -419,7 +419,7 @@ exports[`while fetching apps loading spinner matches the snapshot 2`] = `
className="col-3 text-r align-center"
>
<Link
to="/catalog"
to="/ns/default/catalog"
>
<button
className="deploy-button button button-accent"
Expand Down Expand Up @@ -490,7 +490,7 @@ exports[`while fetching apps matches the snapshot 1`] = `
className="col-3 text-r align-center"
>
<Link
to="/catalog"
to="/ns/default/catalog"
>
<button
className="deploy-button button button-accent"
Expand Down
5 changes: 4 additions & 1 deletion dashboard/src/components/Catalog/CatalogItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,10 @@ const CatalogItem: React.SFC<ICatalogItemProps> = props => {
let subIcon;
if (type === "chart") {
tag1 = (
<Link className="ListItem__content__info_tag_link" to={`/catalog/${repoName}`}>
<Link
className="ListItem__content__info_tag_link"
to={`/ns/${namespace}/catalog/${repoName}`}
>
{repoName}
</Link>
);
Expand Down
2 changes: 1 addition & 1 deletion dashboard/src/components/Catalog/__snapshots__/CatalogItem.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ exports[`should render an item 1`] = `
tag1Content={
<Unknown
className="ListItem__content__info_tag_link"
to="/catalog/undefined"
to="/ns/kubeapps/catalog/undefined"
/>
}
title="foo"
Expand Down