Ensure AppRepo secret has owner references UID set. #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1655 . With commit d5b277c, while adding the app repo validation of #1534, we inadvertently caused an app repo secret to be created without the owner reference UID.
This was because, prior to that change, the secret was not instantiated until we had created the repo with its UID, wherease after the change, the secret and app repo are instantiated in memory together before the app repo is actually created, so the secret ends up not knowing the UID of the app repo.
This was not caught by our tests because the
client-gotest fake does not set UIDs when creating objects (by default, though apparently we could add a reactor to fake this).