Add initial helm post renderer. #1670
Conversation
| "bytes" | ||
| "io" | ||
|
|
||
| "gopkg.in/yaml.v3" |
There was a problem hiding this comment.
I'm curious, is it needed to use v3 or is just to use the latest?
There was a problem hiding this comment.
It was just to use the latest. The only difference that's relevant is that v3 has a default tab intent of 4 spaces, as well as a SetIndent() function. I'll switch to v2 since I'd not realised v3 isn't yet stable/released.
| modifiedManifests = bytes.NewBuffer([]byte{}) | ||
| encoder := yaml.NewEncoder(modifiedManifests) | ||
| defer encoder.Close() | ||
| encoder.SetIndent(2) |
There was a problem hiding this comment.
isn't this the default?
There was a problem hiding this comment.
It is the default for v2 but not v3.
| value: env_value | ||
| image: example.com/bitnami/nginx:1.16.1-debian-10-r42 | ||
| name: container-name | ||
| restartPolicy: Never |
There was a problem hiding this comment.
mmh, I see it's in alphabetical order, what does it? Is it reliable?
There was a problem hiding this comment.
Yes, the output is reliably ordered. I assume the reason is that when the import happens, ordered yaml dicts are imported into explicitly unordered go maps.
| "bytes" | ||
| "io" | ||
|
|
||
| "gopkg.in/yaml.v3" |
There was a problem hiding this comment.
It was just to use the latest. The only difference that's relevant is that v3 has a default tab intent of 4 spaces, as well as a SetIndent() function. I'll switch to v2 since I'd not realised v3 isn't yet stable/released.
| modifiedManifests = bytes.NewBuffer([]byte{}) | ||
| encoder := yaml.NewEncoder(modifiedManifests) | ||
| defer encoder.Close() | ||
| encoder.SetIndent(2) |
There was a problem hiding this comment.
It is the default for v2 but not v3.
| value: env_value | ||
| image: example.com/bitnami/nginx:1.16.1-debian-10-r42 | ||
| name: container-name | ||
| restartPolicy: Never |
There was a problem hiding this comment.
Yes, the output is reliably ordered. I assume the reason is that when the import happens, ordered yaml dicts are imported into explicitly unordered go maps.
Ref #1617 . Adds an initial helm post-renderer which will be updated in subsequent PRs to add the image pulls secret when relevant.