New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle dockerhub secrets special case. Allow optional protocol. #1674

Merged

absoludity merged 1 commit into master from fix-credential-check

Apr 19, 2020

Contributor

absoludity commented Apr 17, 2020

Ref: #1617 . Updates the imagePullSecret injection in the post renderer for two cases:

Dockerhub images use "docker.io" as the registry domain in the image ref (docker's reference library even adds it as such), while the credential in docker configs must be keyed with "https://index.docker.io/v1/".
general registry domains in the docker credentials can be listed with or without an explicit protocol (https), so we update to append the imagePullSecret as long as the domain itself matches.


          Handle dockerhub secrets special case. Allow optional protocol.

0f37f5f

absoludity requested a review from andresmgot

April 17, 2020 04:38

andresmgot approved these changes

View reviewed changes

absoludity merged commit 06e4f3a into master

absoludity deleted the fix-credential-check branch

April 19, 2020 22:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet