Postrenderer support resourcelists #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
approved these changes
Apr 21, 2020
| "PodTemplateList": struct{}{}, | ||
| "ReplicaSetList": struct{}{}, | ||
| "ReplicationControllerList": struct{}{}, | ||
| "StatefulSetList": struct{}{}, |
There was a problem hiding this comment.
AFAIK, just "List" is also a valid resource type
There was a problem hiding this comment.
As far as I know, this is only used for the top level which the renderer never sees, but I've added it anyway.
Comment on lines
85
to
86
| if _, ok := resourceListTypes[kind]; ok { | ||
| if items, ok := resource["items"]; ok { |
There was a problem hiding this comment.
can't we just check if the resource has the key "items" to know if it's a list? That may be a slightly slower (since we would be processing list for other than workloads) but safer and we would need to maintain less hard-coded types.
There was a problem hiding this comment.
We could, and it would work now. I thought it better to be explicit, since we don't control the API, but perhaps it would be simpler. Updating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback from previous PR, this updates to handle both CronJobs and all resource list types.
Ref: #1617