Fix YAML parsing for keys with dots and slashes #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absoludity
approved these changes
Apr 24, 2020
dashboard/src/shared/schema.ts
Outdated
| } | ||
|
|
||
| function unescapePath(path: string[]): string[] { | ||
| // jsonpath scapes slashes to not mistake then with objects so we need to revert that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
So there are two issues when parsing a YAML that have
.and/:.were interpreted as objects so if the key wasa.b, it was interpreted asa: {b:}/is escaped as~1to avoid interpreting them as objects and we were not replacing that back.I have modified our code to simply use
/as the notification for objects (e.g.a.b.c->a/b/c) which is the default for JSON patch. I have also added a step to unescape the character~1.Applicable issues