Remove post-install annotation for apprepositories #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had added this to ensure that during installation of Kubeapps, the creation of the app repository resources wouldn't trigger a sync job to run before the upgrade job updates the schema. But one case we did not anticipate is that if the installation is held up (network issues or similar) and the helm install fails, the resources won't be present. I think it's better to ensure they are always present so that the sync job can eventually sync them (and update to safely migrate the schema rather than recreating it - as per vmware-tanzu#1560).
andresmgot
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had added this to ensure that during installation of Kubeapps, the
creation of the app repository resources wouldn't trigger a sync job
to run before the upgrade job updates the schema. But one case we did
not anticipate is that if the installation is held up (network issues
or similar) and the helm install fails, the resources won't be present.
I think it's better to ensure they are always present so that the sync
job can eventually sync them (and update to safely migrate the schema
rather than recreating it - as per #1560).
Description of the change
As above
Benefits
If the helm install command fails because a post-install job cannot run (yet), all resources are still present on the cluster.
Possible drawbacks
AppRepository creation could trigger a sync job before the backend schema is recreated, which could mean another cycle until the repo is scanned (possibly).
Applicable issues
Additional information