Ensure that the correct cluster is queried by authgate for catalog. #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absoludity
added a commit
that referenced
this pull request
Sep 16, 2020
Required to be able to verify a users access to charts in a given namespace in the authgate check. Followed up by #2038
Base automatically changed from
2026-dashboard-chart-urls-cluster-aware
to
master
September 16, 2020 02:07
absoludity
force-pushed
the
2026-auth-gate-cluster-aware
branch
from
02572f6 to
7eb47e3
Compare
|
Still debugging with the fix on TKG, hence draft. |
|
...and verified this allows viewing the catalog and installing on TKG with the aforementioned setup :) |
andresmgot
approved these changes
Sep 16, 2020
pkg/auth/auth.go
Outdated
| @@ -116,6 +118,7 @@ func NewAuth(token string) (*UserAuth, error) { | |||
| // ValidateForNamespace checks if the user can access secrets in the given | |||
| // namespace, as a check of whether they can view the namespace. | |||
| func (u *UserAuth) ValidateForNamespace(namespace string) (bool, error) { | |||
|
|
|||
There was a problem hiding this comment.
linters wouldn't be happy with this extra line
There was a problem hiding this comment.
Like I did for the frontend lint/prettier, let's enforce CI to fail if lint is found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Updates the auth gate so that when requesting the charts available for a cluster and namespace, that it queries that cluster rather than using the incluster config.
Benefits
On TKG (or otherwise) when Kubeapps is installed on a cluster itself without OIDC but configured for OIDC for the workload clusters, enables viewing the catalog of charts.
Applicable issues
Fixes #2026
Additional information
See #2037