Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid irrelevant changes in diff #2104

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Avoid irrelevant changes in diff #2104

merged 1 commit into from
Oct 13, 2020

Conversation

andresmgot
Copy link
Contributor

Description of the change

Avoid showing non important changes (like deleted blank lines), when showing the difference between the default values and the ones to submit.

Screenshot from 2020-10-08 15-34-36

Note that these blank lines (and other changes) are performed when the values are parsed as YAML objects (in order to react to a change in the form).

Applicable issues

Copy link
Contributor

@absoludity absoludity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - more than a few times I've had to manually avoid this in a video demo. But will this do more than whitespace formatting and also reformat default some yaml to json values as in #1756, or is that just when inserting data?

@andresmgot
Copy link
Contributor Author

But will this do more than whitespace formatting and also reformat default some yaml to json values as in #1756, or is that just when inserting data?

Yes, that's only when data has been modified so it's unrelated to this PR. That issue is related to how JSON patches are applied (when calculating modifications when upgrading).

@andresmgot andresmgot merged commit af43da4 into master Oct 13, 2020
@andresmgot andresmgot deleted the differentialCode branch November 26, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes tab shows a lot of whitespace differences
2 participants