Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor DRY changes in CI #2618

Merged
merged 3 commits into from
Mar 29, 2021
Merged

Minor DRY changes in CI #2618

merged 3 commits into from
Mar 29, 2021

Conversation

antgamdia
Copy link
Contributor

Description of the change

This PR simply performs some minor refactor, extracting the hardcoded variables to CircleCI parameters. Furthermore, it names some of the steps so that the visualization in the CI dashboard is clearer at a glance.

Benefits

Better CI visualization and DRY improvements.

Possible drawbacks

N/A

Applicable issues

Additional information

N/A

Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antgamdia antgamdia merged commit 84ccb4b into master Mar 29, 2021
@antgamdia antgamdia deleted the minor-dry-ci-fixes branch March 29, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants