Add missing rolebinding for the CI user #3556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This minor PR just adds a missing rolebinding (granting read on apprepositories) to the CI SA token we use as "edit-token".
Benefits
CI will work in GKE (well, not only GKE, but any CI workflow not using the OIDC login)
Possible drawbacks
None, but I wonder if this change is also required for some users. Not sure, but I'll drop a line in the release notes, just in case.
Applicable issues
N/A
Additional information
Rubber-stamping as it has been tested at https://app.circleci.com/pipelines/github/kubeapps/kubeapps/4497/workflows/17a5635f-fcfc-48f6-a3ec-5da8bc778b65