fix for Flux plugin requires an additional config getter #3560 #3582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gfichtenholt
commented
Oct 12, 2021
gfichtenholt
commented
- a few integration tests for flux v2 plug in were added/refactored
|
So there is quite a bit of "noise" in this PR, which for the most part feel free to ignore. The main things to double check is in utils.go, called |
absoludity
approved these changes
Oct 13, 2021
| @@ -228,7 +223,7 @@ func kubeGetPodNames(t *testing.T, namespace string) (names []string, err error) | |||
| // will create a service account with cluster-admin privs and return the associated | |||
| // Bearer token (base64-encoded) | |||
| func kubeCreateAdminServiceAccount(t *testing.T, name, namespace string) (string, error) { | |||
| t.Logf("+kubeCreateServiceAccount(%s,%s)", name, namespace) | |||
| t.Logf("+kubeCreateAdminServiceAccount(%s,%s)", name, namespace) | |||
There was a problem hiding this comment.
phew I got scared for a second before I realised this code is part of the integration test utilities :P
| // it appears that if service account is deleted before the helmrelease object that uses it, | ||
| // when you try to delete the helmrelease, the "delete" operation gets stuck and the only | ||
| // way to get it "unstuck" is to edit the CRD and remove the finalizer. | ||
| // So we'll cleanup the service account only after the corresponding helmrelease has been deleted |
| @@ -71,7 +70,7 @@ func NewServer(configGetter server.KubernetesConfigGetter) (*Server, error) { | |||
| return nil, err | |||
| } else { | |||
| return &Server{ | |||
| clientGetter: clientGetter, | |||
| clientGetter: newClientGetter(configGetter), | |||
There was a problem hiding this comment.
Great, so the cache is configured with the background client while the server (handling user requests) still always uses the provided config getter (that gets authz from the context).
| md, ok := metadata.FromIncomingContext(ctx) | ||
| if !ok { | ||
| return "", nil | ||
| return "", fmt.Errorf("missing authorization metadata") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.