Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show http or https when deploying with LoadBalancer #3595

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

antgamdia
Copy link
Contributor

Description of the change

I've noticed I had this uncommitted minor change: displaying httpS if the port is 443 in the installation notes. Even if it is a stop-gap solution (not every HTTP over TLS is under 443 port), it will cover a wide range of deployments using the std port.

Benefits

Navigating to the generated link will no longer result in a 404 page if using a loadbalancer that only exposes the :443 socket (and no redirection has been configured)

Possible drawbacks

A user defining a plain HTTP protocol listening at :443 will get the error page... but, it's their fault for using an IANA-reserved port :P

Applicable issues

N/A

Additional information

N/A

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@absoludity
Copy link
Contributor

A user defining a plain HTTP protocol listening at :443 will get the error page... but, it's their fault for using an IANA-reserved port :P

Haha - yes, agree.

@antgamdia antgamdia merged commit e9b40b3 into vmware-tanzu:master Oct 19, 2021
@antgamdia antgamdia deleted the httpsNotes branch October 19, 2021 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants