Show http or https when deploying with LoadBalancer #3595
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
I've noticed I had this uncommitted minor change: displaying httpS if the port is 443 in the installation notes. Even if it is a stop-gap solution (not every HTTP over TLS is under 443 port), it will cover a wide range of deployments using the std port.
Benefits
Navigating to the generated link will no longer result in a 404 page if using a loadbalancer that only exposes the :443 socket (and no redirection has been configured)
Possible drawbacks
A user defining a plain HTTP protocol listening at :443 will get the error page... but, it's their fault for using an IANA-reserved port :P
Applicable issues
N/A
Additional information
N/A