Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump stylelint, stylelint-config-recommended-scss and stylelint-scss in /dashboard #3641

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 22, 2021

Bumps stylelint, stylelint-config-recommended-scss and stylelint-scss. These dependencies needed to be updated together.
Updates stylelint from 13.13.1 to 14.0.0

Release notes

Sourced from stylelint's releases.

14.0.0

Migrating to 14.0.0 guide.

  • Removed: Node.js 10 support (#5303).
  • Removed: syntax option (#5297).
  • Removed: configOverrides option (#5530).
  • Removed: rules deprecated in 13.7.0 (#5295).
  • Removed: function-calc-no-invalid rule (#5296).
  • Changed: ignoreFiles to be extendable (#5596).
  • Security: addressed ReDoS issue with regex in indentation (#5539).
  • Added: TypeScript type definitions (#5582).
  • Added: customSyntax option as a property in the configuration object (#5538).
  • Added: overrides property to configuration object (#5521).
  • Added: disableFix as secondary option to rules property in the configuration object (#5460).
  • Added: quiet option to Node.js API (#5542).
  • Added: color-hex-alpha rule (#5316).
  • Added: custom-property-no-missing-var-function rule (#5317).
  • Added: function-calc-no-unspaced-operator autofix (#5273).
  • Added: ignoreFunctions: [] to length-zero-no-unit (#5314).
  • Added: ignoreAtRules: [] to no-invalid-position-at-import (#5520).
  • Added: ignoreProperties: [] to number-max-precision (#5421).
  • Fixed: "No files matching the pattern" when using backslash paths on Windows (#5386).
  • Fixed: function-url-quotes problem messages to be consistent with other *-quotes rules (#5488).
  • Fixed: length-zero-no-unit false positives for flex property (#5315).
  • Fixed: media-feature-name-no-unknown false positives for prefers-contrast (#5428).
  • Fixed: media-feature-name-no-unknown false positives for dynamic-range & video-dynamic-range (#5613).
  • Fixed: media-feature-name-value-allowed-list TypeError for spaceless condition (#5581).
  • Fixed: property-no-unknown false positives for Less maps (#5381).
  • Fixed: selector-class-pattern false positives for Less parametric mixins (#5378).
  • Fixed: max-empty-lines autofix for Less comments (#5507).
  • Fixed: named-grid-areas-no-invalid false negatives for grid and grid-template shorthand properties (#5514).
  • Fixed: unit-no-unknown false positives for nested property declarations (#5500).
Changelog

Sourced from stylelint's changelog.

14.0.0

Migrating to 14.0.0 guide.

  • Removed: Node.js 10 support (#5303).
  • Removed: syntax option (#5297).
  • Removed: configOverrides option (#5530).
  • Removed: rules deprecated in 13.7.0 (#5295).
  • Removed: function-calc-no-invalid rule (#5296).
  • Changed: ignoreFiles to be extendable (#5596).
  • Security: addressed ReDoS issue with regex in indentation (#5539).
  • Added: TypeScript type definitions (#5582).
  • Added: customSyntax option as a property in the configuration object (#5538).
  • Added: overrides property to configuration object (#5521).
  • Added: disableFix as secondary option to rules property in the configuration object (#5460).
  • Added: quiet option to Node.js API (#5542).
  • Added: color-hex-alpha rule (#5316).
  • Added: custom-property-no-missing-var-function rule (#5317).
  • Added: function-calc-no-unspaced-operator autofix (#5273).
  • Added: ignoreFunctions: [] to length-zero-no-unit (#5314).
  • Added: ignoreAtRules: [] to no-invalid-position-at-import (#5520).
  • Added: ignoreProperties: [] to number-max-precision (#5421).
  • Fixed: "No files matching the pattern" when using backslash paths on Windows (#5386).
  • Fixed: function-url-quotes problem messages to be consistent with other *-quotes rules (#5488).
  • Fixed: length-zero-no-unit false positives for flex property (#5315).
  • Fixed: media-feature-name-no-unknown false positives for prefers-contrast (#5428).
  • Fixed: media-feature-name-no-unknown false positives for dynamic-range & video-dynamic-range (#5613).
  • Fixed: media-feature-name-value-allowed-list TypeError for spaceless condition (#5581).
  • Fixed: property-no-unknown false positives for Less maps (#5381).
  • Fixed: selector-class-pattern false positives for Less parametric mixins (#5378).
  • Fixed: max-empty-lines autofix for Less comments (#5507).
  • Fixed: named-grid-areas-no-invalid false negatives for grid and grid-template shorthand properties (#5514).
  • Fixed: unit-no-unknown false positives for nested property declarations (#5500).
Commits
  • 060310c 14.0.0
  • ff4a1ef Prepare CHANGELOG
  • 8d2f6e1 Bump postcss (#5619)
  • f552608 Merge pull request #5618 from stylelint/dependabot/npm_and_yarn/husky-7.0.4
  • 7ed17ad Bump husky from 7.0.2 to 7.0.4
  • 4d9f75e Merge pull request #5617 from stylelint/dependabot/npm_and_yarn/jest-27.3.1
  • bc9dd0b Bump jest from 27.2.5 to 27.3.1
  • 82e2507 Merge pull request #5604 from stylelint/v14
  • 16d259f Update CHANGELOG.md
  • 70b1149 Fix false positives for dynamic-range keywords in media-feature-name-no-unkno...
  • Additional commits viewable in compare view

Updates stylelint-config-recommended-scss from 4.3.0 to 5.0.0

Release notes

Sourced from stylelint-config-recommended-scss's releases.

5.0.0

This release adds over a dozen new rules.

If needed, you can extend the config to turn off any of the new rules.

  • Removed: stylelint less than 14.0.0 from peer dependencies.
  • Changed: updated to stylelint-config-recommended@6.0.0.
  • Added: scss/at-extend-no-missing-placeholder rule.
  • Added: scss/at-if-no-null rule.
  • Added: scss/at-import-no-partial-leading-underscore rule.
  • Added: scss/at-import-partial-extension rule.
  • Added: scss/comment-no-empty rule.
  • Added: scss/declaration-nested-properties-no-divided-groups rule.
  • Added: scss/dollar-variable-no-missing-interpolation rule.
  • Added: scss/function-quote-no-quoted-strings-inside rule.
  • Added: scss/function-unquote-no-unquoted-strings-inside rule.
  • Added: scss/no-duplicate-mixins rule.
  • Added: scss/no-global-function-names rule.
  • Added: scss/operator-no-newline-after rule.
  • Added: scss/operator-no-newline-before rule.
  • Added: scss/operator-no-unspaced rule.
Changelog

Sourced from stylelint-config-recommended-scss's changelog.

5.0.0

This release adds over a dozen new rules.

If needed, you can extend the config to turn off any of the new rules.

  • Removed: stylelint less than 14.0.0 from peer dependencies.
  • Changed: updated to stylelint-config-recommended@6.0.0.
  • Added: scss/at-extend-no-missing-placeholder rule.
  • Added: scss/at-if-no-null rule.
  • Added: scss/at-import-no-partial-leading-underscore rule.
  • Added: scss/at-import-partial-extension rule.
  • Added: scss/comment-no-empty rule.
  • Added: scss/declaration-nested-properties-no-divided-groups rule.
  • Added: scss/dollar-variable-no-missing-interpolation rule.
  • Added: scss/function-quote-no-quoted-strings-inside rule.
  • Added: scss/function-unquote-no-unquoted-strings-inside rule.
  • Added: scss/no-duplicate-mixins rule.
  • Added: scss/no-global-function-names rule.
  • Added: scss/operator-no-newline-after rule.
  • Added: scss/operator-no-newline-before rule.
  • Added: scss/operator-no-unspaced rule.
Commits
Maintainer changes

This version was pushed to npm by jeddy3, a new releaser for stylelint-config-recommended-scss since your current version.


Updates stylelint-scss from 3.21.0 to 4.0.0

Release notes

Sourced from stylelint-scss's releases.

4.0.0

  • Removed: stylelint@13 support.
  • Added: stylelint@14 support.
Changelog

Sourced from stylelint-scss's changelog.

4.0.0

  • Removed: stylelint@13 support.
  • Added: stylelint@14 support.
Commits
Maintainer changes

This version was pushed to npm by jeddy3, a new releaser for stylelint-scss since your current version.


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Oct 22, 2021
@antgamdia
Copy link
Contributor

@dependabot recreate

Bumps [stylelint](https://github.com/stylelint/stylelint), [stylelint-config-recommended-scss](https://github.com/stylelint-scss/stylelint-config-recommended-scss) and [stylelint-scss](https://github.com/stylelint-scss/stylelint-scss). These dependencies needed to be updated together.

Updates `stylelint` from 13.13.1 to 14.0.0
- [Release notes](https://github.com/stylelint/stylelint/releases)
- [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md)
- [Commits](stylelint/stylelint@13.13.1...14.0.0)

Updates `stylelint-config-recommended-scss` from 4.3.0 to 5.0.0
- [Release notes](https://github.com/stylelint-scss/stylelint-config-recommended-scss/releases)
- [Changelog](https://github.com/stylelint-scss/stylelint-config-recommended-scss/blob/master/CHANGELOG.md)
- [Commits](stylelint-scss/stylelint-config-recommended-scss@4.3.0...v5.0.0)

Updates `stylelint-scss` from 3.21.0 to 4.0.0
- [Release notes](https://github.com/stylelint-scss/stylelint-scss/releases)
- [Changelog](https://github.com/stylelint-scss/stylelint-scss/blob/master/CHANGELOG.md)
- [Commits](stylelint-scss/stylelint-scss@3.21.0...v4.0.0)

---
updated-dependencies:
- dependency-name: stylelint
  dependency-type: direct:development
  update-type: version-update:semver-major
- dependency-name: stylelint-config-recommended-scss
  dependency-type: direct:development
  update-type: version-update:semver-major
- dependency-name: stylelint-scss
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/dashboard/stylelint-and-stylelint-config-recommended-scss-and-stylelint-scss-14.0.0 branch from 08283ac to 7a3202f Compare October 22, 2021 08:20
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Copy link
Contributor

The scss linter was bumped to a new version with breaking changes, this PR also perform some little changes to make it compatible again.

Besides, it brings new rules that are preventing the linter to pass. I'm squeezing in some required changes (mainly CSS class renames). See the manual changes here: efcb8ba

cc @absoludity

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@absoludity
Copy link
Contributor

The scss linter was bumped to a new version with breaking changes,

Which PR was that in? I'm assuming I approved and landed it but would have done so only if it'd passed CI, so keen to know how it passed with breaking changes? Was it #3577 ? Ah, and breaking changes that perhaps are just style so not checked by CI at all.

I did see an issue looking at installed packages with the flux plugin, but assumed it was something related to using the new plugin and was going to look today.

this PR also perform some little changes to make it compatible again.

Thanks.

Besides, it brings new rules that are preventing the linter to pass. I'm squeezing in some required changes (mainly CSS class renames). See the manual changes here: efcb8ba

cc @absoludity

+1

@absoludity absoludity merged commit b68045d into master Oct 24, 2021
@absoludity absoludity deleted the dependabot/npm_and_yarn/dashboard/stylelint-and-stylelint-config-recommended-scss-and-stylelint-scss-14.0.0 branch October 24, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants