parameterize VersionsInSummary #3683
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: “satya-dillikar” <“satya.dillikar@gmail.com”>
absoludity
reviewed
Oct 28, 2021
| } | ||
|
|
||
| // packageAppVersionsSummary converts the model chart versions into the required version summary. | ||
| func packageAppVersionsSummaryImpl(versions []models.ChartVersion, versionInSummary VersionsInSummary) []*corev1.PackageAppVersion { |
There was a problem hiding this comment.
I don't see any reason to create a new function? Why not just update the signature of the existing packageAppVersionsSummary function and update the (only) call-site to just pass in the extra VersionsInSummary{MajorVersionsInSummary, MinorVersionsInSummary, PatchVersionsInSummary} ?
added 2 commits
October 28, 2021 17:39
Signed-off-by: “satya-dillikar” <“satya.dillikar@gmail.com”>
Signed-off-by: “satya-dillikar” <“satya.dillikar@gmail.com”>
|
Create a new PR: #3703 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: “satya-dillikar” <“satya.dillikar@gmail.com”>
Description of the change
Parameterize the func packageAppVersionsSummary to take a new param.
Benefits
In future, This new parameter VersionsInSummary can be populated from the configuration files.
Possible drawbacks
None
Applicable issues
Additional information
More proper fix is still pending.