Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kapp-controller plugin to current version. #3724

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Conversation

absoludity
Copy link
Contributor

@absoludity absoludity commented Nov 4, 2021

Signed-off-by: Michael Nelson minelson@vmware.com

Description of the change

This PR just updates the (very) outdated kapp-controller plugin to match the current carvel k8s API.

The nice thing is that since the Kubeapps dashboard is using the aggregated API, running Kubeapps with both helm and carvel plugins:

--- a/docs/user/manifests/kubeapps-local-dev-values.yaml
+++ b/docs/user/manifests/kubeapps-local-dev-values.yaml
@@ -15,6 +15,11 @@ postgresql:
   existingSecret: postgresql-db
 kubeappsapis:
   replicaCount: 1
+  enabledPlugins:
+    - helm
+    - kapp-controller
+  image:
+    tag: dev5
 ingress:
   enabled: true
   hostname: localhost

enables viewing a combined catalog:

kubeapps-carvel

Benefits

Carvel plugin works (only get available packages, and even that is missing data).

Possible drawbacks

None.

Applicable issues

Additional information

cc @migmartri

I'll follow-up with another PR that adds more metadata (icon, description etc.) to the available package summaries.

Signed-off-by: Michael Nelson <minelson@vmware.com>
Copy link
Contributor

@migmartri migmartri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @absoludity!

if configGetter == nil {
return nil, status.Errorf(codes.Internal, "configGetter arg required")
}
// The Kapp Controller plugin currently supports interactions with
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it that now we support other clusters?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing any reason why we wouldn't... we use the users cred to whatever cluster is in the context. As long as kapp-controller is installed there, it should work fine (but haven't tested it). I needed to update this because the UI always sends the cluster with the request anyway. If there's a problem we can make it conditional (I'll check it at some point).

@absoludity absoludity merged commit 818d82e into master Nov 4, 2021
@absoludity absoludity deleted the 3221-carvel-1 branch November 4, 2021 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants