use two-step form for provisioning service instances #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A two step form allows us to cleanly separate input that Kubeapps needs from the generalised input from the Service Broker's schema. The first form simply asks for the name of the Service Instance, and the second form renders the parameters using the broker-provided instanceCreateParameterSchema.
andresmgot
approved these changes
Jun 22, 2018
| @@ -116,13 +120,23 @@ class ProvisionButton extends React.Component<IProvisionButtonProps, IProvisionB | |||
| }); | |||
| }; | |||
|
|
|||
| public handleBackButton = (e: React.MouseEvent<HTMLButtonElement>) => { | |||
| e.preventDefault(); | |||
| this.setState({ ...this.state, displayNameForm: true }); | |||
There was a problem hiding this comment.
do you need the ...this.state?
There was a problem hiding this comment.
oops no, thanks for catching that, I was debugging something and left that in!
| {displayLabel && ( | ||
| <label htmlFor={id}> | ||
| {label} | ||
| {required && " *"} |
There was a problem hiding this comment.
is quite obvious but a line at the end saying * Mandatory fields would be nice
There was a problem hiding this comment.
What about changing it to (required)? I want to avoid adding an extra thing at the end of the form, the markup is already fairly messy.
If you're worried about users simply missing the required fields, the required html attribute is set so browsers should catch the error before forms are submitted.
|
@prydonius Can we make the form that just asks for the name smaller, please? |
|
the changes lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A two step form allows us to cleanly separate input that Kubeapps needs
from the generalised input from the Service Broker's schema. The first
form simply asks for the name of the Service Instance, and the second
form renders the parameters using the broker-provided instanceCreateParameterSchema.
fixes #362