Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing URLEncode in some mgs #3745

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

antgamdia
Copy link
Contributor

Description of the change

We had a card in our board regarding a "/" not being properly handled at some point. Unfortunately, I wasn't able to fully remember what this was about, so I'll remove it and open a proper issue next time I face it.

However, I did find a couple of missing URLDecode calls preventing some loading messages to render properly, wherefore this PR.

Benefits

No more "foo%2Fbar" loading msgs.

Possible drawbacks

N/A

Applicable issues

N/A

Additional information

N/A

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Copy link
Contributor

@absoludity absoludity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, yes, I thought I'd seen it as an actual title at some point, but wasn't able to reproduce either.

@antgamdia antgamdia merged commit a79ee88 into vmware-tanzu:master Nov 11, 2021
@antgamdia antgamdia deleted the fixMinorEncode branch November 11, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants