Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI dashboard tests should garbage-collect earlier. #3803

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

absoludity
Copy link
Contributor

@absoludity absoludity commented Nov 23, 2021

Signed-off-by: Michael Nelson minelson@vmware.com

Description of the change

Still seeing some dashboard test runs on CI failing when workers get close to 1Gb (see details in comment). Forgot that we probably need to leave some memory for other processes, so updating to cause GC when a worker has 512Mb old mem.

Benefits

Hopefully more stable CI.

Possible drawbacks

Applicable issues

  • fixes #

Additional information

Signed-off-by: Michael Nelson <minelson@vmware.com>
@absoludity
Copy link
Contributor Author

Heap size looks much more healthy in tests now:

 PASS  src/components/OperatorView/OperatorHeader.test.tsx (256 MB heap size)
 PASS  src/components/DeploymentFormBody/AdvancedDeploymentForm.test.tsx (275 MB heap size)
 PASS  src/components/Icon/Icon.test.tsx (304 MB heap size)
 PASS  src/components/ConfirmDialog/ConfirmDialog.test.tsx (324 MB heap size)
 PASS  src/components/DeploymentFormBody/DifferentialSelector.test.tsx (208 MB heap size)
 PASS  src/components/js/Card/components/CardImage/CardImage.test.js (293 MB heap size)
 PASS  src/components/js/Card/components/CardTitle/CardTitle.test.js (333 MB heap size)
 PASS  src/components/js/Card/components/CardHeader/CardHeader.test.js (352 MB heap size)
 PASS  src/components/js/Row/Row.test.js (235 MB heap size)
 PASS  src/components/js/Table/components/TableRow/TableRow.test.js (316 MB heap size)
 PASS  src/components/js/Card/components/CardFooter/CardFooter.test.js (369 MB heap size)
 PASS  src/components/OperatorView/OperatorCapabilityLevel.test.tsx (358 MB heap size)
 PASS  src/components/js/Card/components/CardBlock/CardBlock.test.js (259 MB heap size)
 PASS  src/components/js/Card/components/CardText/CardText.test.js (334 MB heap size)
 PASS  src/components/AppView/AppNotes/AppNotes.test.tsx (393 MB heap size)
 PASS  src/components/NotFound/NotFound.test.tsx (383 MB heap size)

Rubber stamping this.

@absoludity absoludity merged commit 37e7eca into vmware-tanzu:master Nov 23, 2021
@absoludity absoludity deleted the lower-dashboard-test-mem branch November 23, 2021 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant