Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong metadata in the chart values #3808

Merged
merged 7 commits into from
Nov 23, 2021

Conversation

antgamdia
Copy link
Contributor

@antgamdia antgamdia commented Nov 23, 2021

Description of the change

After some changes in the chart, I've noticed it was yielding some errors in the readme-generator tool we are using. This PR is to address these minor issues so that the readme can get autogenerated again.

Benefits

Readme working again :)

Possible drawbacks

N/A

Applicable issues

N/A

Additional information

This PR is staked over #3807 to avoid dealing with conflicts as I assume it will get merged straight away.

The only relevant commit is: 7a369c1

Carlos Rodriguez Hernandez and others added 6 commits November 23, 2021 07:08
Signed-off-by: Carlos Rodriguez Hernandez <carlosrh@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia antgamdia changed the base branch from master to carvel November 23, 2021 11:23
@antgamdia antgamdia changed the base branch from carvel to master November 23, 2021 11:23
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>

Conflicts:
	chart/kubeapps/values.yaml
Copy link
Contributor

@absoludity absoludity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Antonio.

@antgamdia antgamdia merged commit bd874d9 into vmware-tanzu:master Nov 23, 2021
@antgamdia antgamdia deleted the fixReadme branch November 23, 2021 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants