Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint warning if console.log are left #3813

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

antgamdia
Copy link
Contributor

Description of the change

Minor PR adding just an eslint warning if the committed code includes unnoticed console.log. I thought it was enabled by default, but some previous updates in the eslint config must have disabled it.

Benefits

I won't commit again (or at least, our CI won't let it pass) code with console.log eventually useful for debugging a unit test :P

Possible drawbacks

N/A

Applicable issues

N/A

Additional information

I'd say it was marked (in the past) as an error, which prevented eventual console statements when developing, Now it is a warning, we should be able to run yarn start without any issues.

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Copy link
Contributor

@absoludity absoludity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks.

@antgamdia antgamdia merged commit f13bd34 into vmware-tanzu:master Nov 25, 2021
@antgamdia antgamdia deleted the eslint-console branch November 25, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants