Add eslint warning if console.log are left #3813
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Minor PR adding just an eslint warning if the committed code includes unnoticed
console.log
. I thought it was enabled by default, but some previous updates in the eslint config must have disabled it.Benefits
I won't commit again (or at least, our CI won't let it pass) code with console.log eventually useful for debugging a unit test :P
Possible drawbacks
N/A
Applicable issues
N/A
Additional information
I'd say it was marked (in the past) as an
error
, which prevented eventual console statements when developing, Now it is a warning, we should be able to runyarn start
without any issues.