Switch dashboard's createDockerRegistrySecret to use resources API. #3916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
castelblanque
approved these changes
Dec 9, 2021
absoludity
force-pushed
the
3896-secrets-backend-2
branch
from
be5935e to
f201bff
Compare
absoludity
force-pushed
the
3896-secrets-dashboard-1
branch
from
29ec032 to
7182417
Compare
absoludity
force-pushed
the
3896-secrets-backend-2
branch
from
f201bff to
7ebab5f
Compare
absoludity
force-pushed
the
3896-secrets-dashboard-1
branch
from
7182417 to
3ef2bee
Compare
absoludity
force-pushed
the
3896-secrets-backend-2
branch
from
7ebab5f to
275bf2d
Compare
absoludity
force-pushed
the
3896-secrets-dashboard-1
branch
from
3ef2bee to
64ff9c3
Compare
antgamdia
approved these changes
Dec 13, 2021
| namespace, | ||
| ); | ||
| dispatch(createImagePullSecret(secret)); | ||
| await Secret.createPullSecret(currentCluster, name, user, password, email, server, namespace); |
There was a problem hiding this comment.
Not sure if we can/want use the Context here instead of passing the cluster/ns directly
There was a problem hiding this comment.
Yep, we probably can now, but will need to update the form props and call-sites etc.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
stale
|
We probably want to keep this PR open. |
stale
bot
removed
stale
absoludity
force-pushed
the
3896-secrets-backend-2
branch
from
275bf2d to
6866aea
Compare
Signed-off-by: Michael Nelson <minelson@vmware.com>
absoludity
force-pushed
the
3896-secrets-dashboard-1
branch
from
64ff9c3 to
fe69999
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Nelson minelson@vmware.com
Description of the change
Switches the
Secret.createDockerRegistrySecrethelper from using the k8s API directly to using the resources plugin.Tested IRL to ensure both the dashboard change and the backend grpc function work together as expected (which they do).
Benefits
Possible drawbacks
Applicable issues
Additional information
Next up is switching the dashboard's
Secret.listto use the plugin'sGetSecretNameswhich will be trickier, as it also involves updating the dashboard to no longer require the secret data for the UX interaction.