Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger fetch of package status after resources are updated. #4256

Merged
merged 2 commits into from
Feb 11, 2022

Conversation

absoludity
Copy link
Contributor

Signed-off-by: Michael Nelson minelson@vmware.com

Description of the change

Fixes an issue whereby a package installs successfully but the upgrade/delete buttons remain disabled.

With this change, we refresh the package status whenever a bunch of resources are processed.

Benefits

When using Flux plugin to install a package, the buttons enable once the package is reconciled.

Possible drawbacks

Applicable issues

Additional information

Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Copy link
Contributor

@antgamdia antgamdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, given that we are already fetching the info periodically, it's a great opportunity to also update the pkg status. Thanks!

Also, I'd say we may want something similar in the "Applications" view. Once they are loaded, we won't get refreshed anymore (so they could have failed or reconciled without, but the displayed status will be still the same)

@absoludity absoludity merged commit d4487af into main Feb 11, 2022
@absoludity absoludity deleted the 3695-update-app-status branch February 11, 2022 00:16
@absoludity
Copy link
Contributor Author

Awesome, given that we are already fetching the info periodically, it's a great opportunity to also update the pkg status. Thanks!

Also, I'd say we may want something similar in the "Applications" view. Once they are loaded, we won't get refreshed anymore (so they could have failed or reconciled without, but the displayed status will be still the same)

Hmm... less of a priority, but yes, we could update tiles so that those in non-final states can refresh (though even then, there's no "final" state for flux/carvel where they can continually update the installed app etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants