Filter carvel available applications using the filter options. #4629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Nelson <minelson@vmware.com>
antgamdia
approved these changes
Apr 28, 2022
| intersection := true | ||
| for _, category := range categories { | ||
| if _, ok := metadataCategoriesHash[category]; !ok { | ||
| intersection = false |
There was a problem hiding this comment.
If false, can't we just break the loop and eagerly return it?
There was a problem hiding this comment.
Yep, good point.
| @@ -58,6 +58,7 @@ reset-dev-kubeapps: | |||
| deploy-kapp-controller: | |||
| kubectl --kubeconfig=${CLUSTER_CONFIG} apply -f https://github.com/vmware-tanzu/carvel-kapp-controller/releases/download/v0.35.0/release.yml | |||
| kubectl --kubeconfig=${CLUSTER_CONFIG} apply -f https://raw.githubusercontent.com/vmware-tanzu/carvel-kapp-controller/develop/examples/packaging-with-repo/package-repository.yml | |||
| kubectl --kubeconfig=${CLUSTER_CONFIG} apply -f ./docs/howto/manifests/tce-package-repository.yaml | |||
Signed-off-by: Michael Nelson <minelson@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Nelson minelson@vmware.com
Description of the change
Turns out the filtering just wasn't implemented yet.
This PR adds filtering of available packages for the carvel plugin, currently filtering by query and categories.
Benefits
See linked issue.
Possible drawbacks
Applicable issues
Additional information
Built locally and verified it works as expected. Also noticed that the categories filter is still being done client-side, which will not work correctly with pagination etc. I'll check if we have an existing issue for that.