Update go deps #4674
Merged
Update go deps #4674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
absoludity
approved these changes
May 9, 2022
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> Conflicts: go.sum
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
antgamdia
commented
May 10, 2022
| @@ -8,7 +8,6 @@ import ( | |||
| "strings" | |||
| "time" | |||
|
|
|||
| kappctrlinstalled "github.com/vmware-tanzu/carvel-kapp-controller/cli/pkg/kctrl/cmd/package/installed" | |||
There was a problem hiding this comment.
This dependency (the only one occurrence) was blocking the upgrade path for the kapp-controller itself (it is still pointing to v0.27). I've replaced it with the actual value %s-%s-values" of the template + a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
To better trace any error, this is a follow-up of #4671 just updating the transitive go dependencies (the main ones, I'll defer them to dependabot, so that we can be testing each one separately)
Benefits
Up to date deps.
Possible drawbacks
N/A
Applicable issues
Additional information
Let's see if the CI thinks otherwise :P