Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getting-started.md #471

Merged
merged 3 commits into from
Aug 16, 2018
Merged

Update getting-started.md #471

merged 3 commits into from
Aug 16, 2018

Conversation

natiki
Copy link
Contributor

@natiki natiki commented Aug 12, 2018

Added instructions for Windows users. Made use of the inbuilt certutil command to do the base64 decoding.

Added instructions for Windows users. Made use of the inbuilt certutil command to do the base64 decoding.
@prydonius
Copy link
Contributor

@sameersbn would you have some time to test out these instructions on Windows?

```
For Linux:

```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to move the following two commands outside the platform specific instructions right?

kubectl create serviceaccount kubeapps-operator
kubectl create clusterrolebinding kubeapps-operator --clusterrole=cluster-admin --serviceaccount=default:kubeapps-operator 

kubectl create serviceaccount kubeapps-operator
kubectl create clusterrolebinding kubeapps-operator --clusterrole=cluster-admin --serviceaccount=default:kubeapps-operator
kubectl get secret $(kubectl get serviceaccount kubeapps-operator -o jsonpath='{.secrets[].name}') -o jsonpath='{.data.token}' | base64 --decode
```
For Windows:

Create a file called GetDashToken.cmd with the following lines in it:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format instances of GetDashToken.cmd as GetDashToken.cmd

REM Decode The Token
DEL token.txt
certutil -decode b64.txt token.txt

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this extra new-line character

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@natiki I think you still need to remove this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I saw your comment about readability, we can leave it in

certutil -decode b64.txt token.txt

```
Open a command prompt and run the GetDashToken.cmd Your token can be found in the token.txt file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the missing period .


Create a file called GetDashToken.cmd with the following lines in it:

```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use bat to apply syntax highlighting to this block

f.e.

REM my comment
DEL s.txt

@sameersbn
Copy link
Contributor

ping @natiki

@sameersbn. I applied all your changes except for removing the blank lines in the batch file as I believe they add readability. If you really want them out then feel free to take them out.
@natiki
Copy link
Contributor Author

natiki commented Aug 15, 2018

ping @sameersbn

@sameersbn sameersbn merged commit 2edf2c7 into vmware-tanzu:master Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants