Remove assetsvc

[antgamdia]

Description of the change

This PR finally removes the assetsvc code (note that we deprecated it in versionv2.4.0). This deletion paves the way to tidy up the pkg folder: there is some logic used by both the assetsvc and the helm plugin; now this logic can be safely moved into the kubeapps-apis directory. I'll perform those changes in upcoming PRs.

Benefits

Less unused code !

Possible drawbacks

N/A (hopefully :P)

Applicable issues

• related Remove asset-svc from our codebase + bitnami builds #4847

Additional information

will investigate the CI issues tomorrow

[netlify]

✅ Deploy Preview for kubeapps-dev canceled.

Name	Link
🔨 Latest commit	6916f19
🔍 Latest deploy log	https://app.netlify.com/sites/kubeapps-dev/deploys/62a2126d8231f70008d7d94a

[absoludity]

!!!! Woohoo. Thanks for taking care of moving the pg utils work for now.

[castelblanque]

Thanks! Now Kubeapps feels ligther 😃

[antgamdia]

The current CI issue seems to be a problem when upgrading from a chart that is passing an old flag. Let's see if we can ignore this failure (no, it is not supported by Cobra) or maybe just add the param back until we release a new version.

circleci@ip-172-28-92-82:~/project$ k logs -n kubeapps kubeapps-ci-internal-kubeops-987c457df-lk82s
Error: unknown flag: --assetsvc-url
Usage:
  kubeops [flags]

Flags:
      --burst int                         internal burst capacity (default 15)
      --clusters-config-path string       Configuration for clusters
      --global-repos-namespace string     Namespace of global repositories (default "kubeapps")
      --helm-driver string                which Helm driver type to use
  -h, --help                              help for kubeops
      --list-max int                      maximum number of releases to fetch (default 256)
      --namespace-header-name string      name of the header field, e.g. namespace-header-name=X-Consumer-Groups     
      --namespace-header-pattern string   regular expression that matches only single group, e.g. namespace-header-pattern=^namespace:([\w]+):\w+$, to match namespace:ns:read
      --pinniped-proxy-url string         internal url to be used for requests to clusters configured for credential proxying via pinniped (default "http://kubeapps-internal-pinniped-proxy.kubeapps:3333")
      --qps float32                       internal QPS rate (default 10)
      --timeout int                       Timeout to perform release operations (install, upgrade, rollback, delete) (default 300)
      --user-agent-comment string         UserAgent comment used during outbound requests
  -v, --version                           version for kubeops

Error: unknown flag: --assetsvc-url

[antgamdia]

This is an ugly workaround to get the upgrade test passing... otherwise (see my previous comment), they're gonna fail in both our CI and Bitnami's.
Once we release v2.4.6, we can safely delete it

[castelblanque]

I think it is fine as long as we don't forget to remove it in a later stage.

Thanks!

[antgamdia]

I'm adding a card to our project dashboard... I can't rely on my memory 👴